fix: registration should use internal IP so that we can use tags for firewall rules #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is included in version 1.0.0 🎉 |
MeNsaaH
pushed a commit
that referenced
this pull request
Mar 16, 2022
### [1.0.8](v1.0.7...v1.0.8) (2022-03-16) ### Bug Fixes * registration should use internal IP so that we can use tags for firewall rules ([#4](#4)) ([8926850](8926850))
|
This PR is included in version 1.0.8 🎉 |
github-actions bot
pushed a commit
to aayushprime/terraform-google-gitlab-ci-runner
that referenced
this pull request
Oct 3, 2023
## 1.0.0 (2023-10-03) ### Features * Added module for cache and kubernetes ([DeimosCloud#8](https://github.com/aayushprime/terraform-google-gitlab-ci-runner/issues/8)) ([0978d21](0978d21)) * Conditionally create node pool ([DeimosCloud#12](https://github.com/aayushprime/terraform-google-gitlab-ci-runner/issues/12)) ([2b8b64d](2b8b64d)) ### Bug Fixes * changed module.cache[0].cache_bucket_name -> module.cache.cache_bucket_name ([DeimosCloud#10](https://github.com/aayushprime/terraform-google-gitlab-ci-runner/issues/10)) ([0d1fa07](0d1fa07)) * create additional docker-machines firewall rule to account for multiple deployments overriding each other ([DeimosCloud#5](https://github.com/aayushprime/terraform-google-gitlab-ci-runner/issues/5)) ([9c12581](9c12581)) * fix cache name and optional docker-machine firewall creation ([DeimosCloud#13](https://github.com/aayushprime/terraform-google-gitlab-ci-runner/issues/13)) ([1d53300](1d53300)) * moved cache and gke-runner submodule into the folders directory ([DeimosCloud#11](https://github.com/aayushprime/terraform-google-gitlab-ci-runner/issues/11)) ([8443244](8443244)) * registration should use internal IP so that we can use tags for firewall rules ([DeimosCloud#4](https://github.com/aayushprime/terraform-google-gitlab-ci-runner/issues/4)) ([8926850](8926850)) * update runner machine image to ubuntu-2004 to fix docker installation ([093ba99](093ba99)) * use internal Ip for dummy runner so that firewall rule works ([f57a91f](f57a91f)) * use the same image for spinning up dummy machine and update default runner machine image to COS ([7c24b17](7c24b17))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.