Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetSparker scan import issue #9816

Closed
1 of 3 tasks
MotiejusK opened this issue Mar 25, 2024 · 8 comments
Closed
1 of 3 tasks

NetSparker scan import issue #9816

MotiejusK opened this issue Mar 25, 2024 · 8 comments
Labels

Comments

@MotiejusK
Copy link

MotiejusK commented Mar 25, 2024

Bug description
Issue is either in demo environment (https://demo.defectdojo.org/) either in latest on premise installation .
Tried either sample scan file from https://github.com/DefectDojo/sample-scan-files/blob/master/netsparker/Netsparker_v0.1.json either own file.

Steps to reproduce
Steps to reproduce the behavior:

  1. Go to product
  2. Go to engagement
  3. click import scan
  4. pick netsparker
  5. attach file.
    6.submit

Expected behavior
Scan results imported

Deployment method (select with an X)

  • Docker Compose
  • Kubernetes
  • GoDojo

Sample scan files
https://github.com/DefectDojo/sample-scan-files/blob/master/netsparker/Netsparker_v0.1.json

Screenshots
image

@manuel-sommer
Copy link
Contributor

See PR @MotiejusK

@manuel-sommer
Copy link
Contributor

Hi @MotiejusK , this can be closed

@MotiejusK
Copy link
Author

MotiejusK commented Mar 28, 2024

Shouldn't I do this after I can validate issue is solved?

@mtesauro
Copy link
Contributor

@MotiejusK Since that PR was merged, it will be in Monday's release of 2.33.0 - Monday evening (US Central time) the demo site will be upgraded to 2.33.0. You can either upgrade your installation or try this out in the public demo site once that upgrade happens.

Historically, we've closed issues once the PR is merged that addresses them since those PRs include unit tests to cover the issue they address. If the PR fails to address the issue, another issue can be opened or this issue can be re-opened as well.

I would actually appreciate you re-opening this if the issues isn't resolved in Monday's release of 2.33.0. 👍

@MotiejusK
Copy link
Author

MotiejusK commented May 28, 2024

In generally fix is working, but got into other issue :

An exception error occurred during the report import: 'NoneType' object has no attribute 'encode'. System crashes to import at some line..

I would note that Netsparker json file in sample is quite old. Old one imports well, but current version Netsparker files rises error.

@manuel-sommer
Copy link
Contributor

manuel-sommer commented Jun 3, 2024

@MotiejusK can you please test #10312 ?

@MotiejusK
Copy link
Author

@manuel-sommer where ?

@manuel-sommer
Copy link
Contributor

@MotiejusK see above #10312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants