Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whale-api): Fix swap tx not found index #2170

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented Nov 10, 2023

What this PR does / why we need it:

Fix for random bug swap tx not found in indexer

context: related to client.listpoolpairs (cache/fresh) pull

  • replace IndexError by Log
  • minimise the debugging scope from (com)swap tx to findPair utils
  • retry findPair if undefined

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 74b1335
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/654de2e2862ae80008f87e8b
😎 Deploy Preview https://deploy-preview-2170--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@canonbrother canonbrother changed the title Bug(whale-api): Fix swap tx not found index fix(whale-api): Fix swap tx not found index Nov 10, 2023
@github-actions github-actions bot added the kind/fix Fix a bug label Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2170 (74b1335) into main (dd01b74) will decrease coverage by 0.90%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #2170      +/-   ##
==========================================
- Coverage   92.87%   91.98%   -0.90%     
==========================================
  Files         373      370       -3     
  Lines       11260    11238      -22     
  Branches     1474     1473       -1     
==========================================
- Hits        10458    10337     -121     
- Misses        769      862      +93     
- Partials       33       39       +6     
Files Coverage Δ
...pi/src/module.indexer/model/dftx/composite.swap.ts 77.41% <100.00%> (+0.94%) ⬆️
...ale-api/src/module.indexer/model/dftx/pool.swap.ts 65.30% <100.00%> (-25.26%) ⬇️
...odule.indexer/model/dftx/pool.pair.path.mapping.ts 90.00% <66.66%> (-10.00%) ⬇️

... and 57 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

github-actions bot commented Nov 10, 2023

Docker build preview for jellyfish/apps is ready!

Built with commit 3aeb77d

  • ghcr.io/birthdayresearch/legacy-api:pr-2170
  • ghcr.io/birthdayresearch/playground-api:pr-2170
  • ghcr.io/birthdayresearch/status-api:pr-2170
  • ghcr.io/birthdayresearch/whale-api:pr-2170

You can also get an immutable image with the commit hash

  • ghcr.io/birthdayresearch/legacy-api:3aeb77de91e91f5667fe345efde0b109e1b2062b
  • ghcr.io/birthdayresearch/playground-api:3aeb77de91e91f5667fe345efde0b109e1b2062b
  • ghcr.io/birthdayresearch/status-api:3aeb77de91e91f5667fe345efde0b109e1b2062b
  • ghcr.io/birthdayresearch/whale-api:3aeb77de91e91f5667fe345efde0b109e1b2062b

@canonbrother canonbrother changed the base branch from main to lyka/retry-prevblock-indexer November 10, 2023 07:42
@canonbrother canonbrother force-pushed the canonbrother/fix-swap-tx-pair-not-found-indexer branch from 418b60f to 9c6356f Compare November 10, 2023 07:43
Base automatically changed from lyka/retry-prevblock-indexer to main November 10, 2023 07:57
@canonbrother canonbrother merged commit 97c28a9 into main Nov 14, 2023
33 of 34 checks passed
@canonbrother canonbrother deleted the canonbrother/fix-swap-tx-pair-not-found-indexer branch November 14, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants