Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue setting up the project locally to contribute a plugin #449

Closed
aonawale opened this issue Aug 28, 2024 · 1 comment
Closed

Issue setting up the project locally to contribute a plugin #449

aonawale opened this issue Aug 28, 2024 · 1 comment

Comments

@aonawale
Copy link

I am trying to create a new plugin following the contributing guide here https://github.com/aonawale/analytics/blob/master/CONTRIBUTING.md. I started by installing pnpm globally using npm install -g pnpm because it is the package manager used by the analytics project.

First issue
The npm run setup command failed while installing with this error nan_callbacks.h:55:23: error: ‘AccessorSignature’ is not a member of ‘v8’ #942. I managed to get the installation to complete by following the recommendation here nodejs/nan#942 (comment).

Second issue
After the npm run setup command ran successfully, I ran the next command npm run build the I got another error  ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  analytics@0.8.14 prebuild: "npm run clean && npm run types"

Node version: v20.11.0
NPM version: 10.2.4
PNPM version: 9.9.0

Screenshot 2024-08-28 at 17 24 07
@DavidWells
Copy link
Owner

Hey there. Yeah there might be some weird stuff with the build in newer versions of node or pnpm 😅

Try running with node v16 and/or pnpm 8.7.6

Just tested this out with v16.20.2 and builds work. (pnpm v8.7.6)

Haven't had time to debug dev deps and update the pipeline for newer versions of node/pnpm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants