Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make icon/logo user configurable #205

Closed
Daveiano opened this issue Oct 13, 2023 Discussed in #201 · 0 comments
Closed

Make icon/logo user configurable #205

Daveiano opened this issue Oct 13, 2023 Discussed in #201 · 0 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@Daveiano
Copy link
Owner

Discussed in #201

Originally posted by dystechnic October 4, 2023
Hi,

I'm setting this skin up for an observatory and we would like to change the logo on the pages to the logo of our observatory. But I can't seem to get it to work.
I made 4 versions of the logo corresponding to the sizes op the icon-192x192.png, etc. I've put them in the same dir as the icon files and changed the line in html-head. inc to .
After removing all files from the www-root and adding the png's to the copy_once line in skin.conf I regenerated all pages. But still the original logo is in the top right corner.

What am I doing wrong?

Thanks.

Originally posted by **daveiano** October 4, 2023 Hi!

You are referring to the logo on the top left in the header (the blue one), right?

There is currently no built-in way to change the logo, it is simply included in the template as an SVG: https://github.com/Daveiano/weewx-wdc/blob/3.x/skins/weewx-wdc/includes/ui-shell.inc#L23

You could add your logo as an SVG and include that, this should work, I guess. You could also replace the provided icon with your own (https://github.com/Daveiano/weewx-wdc/blob/3.x/skins/weewx-wdc/includes/icons/wdc.svg).

I did not think that a user would probably want to change the icon, to be honest. I will include an easy method of replacing the icon in the next release - because this sounds like a useful addition to the skin.

Thanks for reaching out!

@Daveiano Daveiano added this to the 3.4.0 milestone Oct 13, 2023
@Daveiano Daveiano added documentation Improvements or additions to documentation and removed needs issue labels Oct 13, 2023
@Daveiano Daveiano changed the title Change icon/logo Make icon/logo user configurable Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant