Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Provide Generic Tests with dbtvault for DataVault 2.0 specific use-cases #116

Open
DVAlexHiggs opened this issue Apr 25, 2022 · 1 comment
Assignees
Labels
feature This is is requesting a new feature

Comments

@DVAlexHiggs
Copy link
Member

DVAlexHiggs commented Apr 25, 2022

Testing is vital in any Data Warehouse.

Here's what we can do today with out-of-the-box dbt (and dbt-utils) tests:

  • We can perform many basic tests such as the Hash key being Unique and Not Null in all of our tables.

  • We can test that there are no orphaned records between hubs, links and satellites (i.e. test to make sure we don't have any satellite records without a corresponding hub record) This would use the relationships_where dbt_utils test.

  • Many, many more, including column type checks between layers using custom tests

  • Other tests which make use of dbt-expectations

These are great and a good starting point, however there are a number of other tests we have experience doing in clients which we have built specifically for certain cases and purposes.

We would like to add these tests to dbtvault as standard, so that users can make use of them in their own projects. This would be hugely beneficial for many reasons!

These would be offered as generic tests that ship with dbtvault and which users could configure and apply to the models which use dbtvault macros.

This is a good example of a custom test we could implement in dbtvault

AB#5375

@DVAlexHiggs DVAlexHiggs added the feature This is is requesting a new feature label Apr 25, 2022
@DVAlexHiggs DVAlexHiggs self-assigned this Apr 25, 2022
@saqib-ali
Copy link

saqib-ali commented Apr 25, 2022

Test Ideas:

  1. Automated check to confirm that all the columns (except for BKs) in the SAT are part of the HASHDIFF. There should be except clause to exclude fields that should not be part of the HASHDIFF e.g. _FIVETRAN_SYNC, LOAD_DATE APPLIED_DATE RECORD_SOURCE.
  2. A duplicate record with same HASHKEY + LOAD_DATE + HASHDIFF should not be inserted into the SAT.

@DVAlexHiggs DVAlexHiggs changed the title [FEATURE] Generic Tests for dbtvault and DataVault 2.0 specific cases [FEATURE] Generic Tests for dbtvault and DataVault 2.0 specific use-cases Apr 25, 2022
@DVAlexHiggs DVAlexHiggs changed the title [FEATURE] Generic Tests for dbtvault and DataVault 2.0 specific use-cases [FEATURE] Provide Generic Tests with dbtvault for DataVault 2.0 specific use-cases Apr 25, 2022
@DVAlexHiggs DVAlexHiggs added feature This is is requesting a new feature and removed feature This is is requesting a new feature labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This is is requesting a new feature
Projects
None yet
Development

No branches or pull requests

2 participants