Add support for multiple network configuration options #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkabrda
suggested changes
May 30, 2022
|
@bkabrda comments addressed except for the service one. If you're wanting me to add service to init_config along with that which is in instance, lmk. |
|
@ryan-dyer-sp thanks for doing the changes. Could you possibly rebase on top of latest |
Signed-off-by: Ryan Dyer <ryan-dyer-sp@users.noreply.github.com>
ryan-dyer-sp
force-pushed
the
add-network-options
branch
from
d18598e to
80e1d62
Compare
|
@bkabrda rebased and CI now passing |
bkabrda
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the network integration to support the current set of options available.
Motivation
need support for ENA metrics in the network integration via puppet
Additional Notes
Describe your test plan
Just manual testing using the module and updating various variables to ensure they rendered conf.yaml contained the correct data.