Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat requirement version bump #328

Open
den-is opened this issue May 19, 2017 · 5 comments
Open

Concat requirement version bump #328

den-is opened this issue May 19, 2017 · 5 comments
Assignees
Milestone

Comments

@den-is
Copy link

den-is commented May 19, 2017

Recently concat has been updated to v4.0.0

Warning: Module 'puppetlabs-concat' (v4.0.0) fails to meet some dependencies:
  'datadog-datadog_agent' (v1.10.0) requires 'puppetlabs-concat' (v2.2.0)

Good to have something like

    {
      "name": "puppetlabs/concat",
      "version_requirement": ">=2.2.0 <5.0.0"
    }
@truthbk
Copy link
Member

truthbk commented May 31, 2017

@den-is if memory serves me well, we pinned to a specific concat version because concat 4.0.0 breaks stuff for older puppet versions (ie. <4). I'll give the latest concat module a whirl, just in case it fixes existing issues, but otherwise we might have to keep this pinned until the next major release.

@truthbk truthbk added this to the triage milestone May 31, 2017
@ColinHebert
Copy link
Contributor

ColinHebert commented Jun 30, 2017

@truthbk FWIW Puppet 5 is now out, dropping support of puppet 3 doesn't seem like a bad idea

@truthbk
Copy link
Member

truthbk commented Aug 11, 2017

@ColinHebert we'll probably do that with the release of a new major release. I would like to do a few things in that release - chiefly make the classes more resource-like and less include-like.... but that might be more work than anticipated.

We definitely have got this in mind!!

@truthbk truthbk self-assigned this Aug 11, 2017
@bittner
Copy link

bittner commented Oct 26, 2017

This dependency is creating a load of issues in our control repo.

Please drop support for Puppet < 4 and upgrade the version requirement.

@den-is
Copy link
Author

den-is commented Oct 26, 2017

This module has really slow development pace, while this is not opensource product.
I'm thinking of dropping it from my env, and writing my own.
Coz dd-agent is not something complex, like nginx or haproxy for example, where you really have benefits of using well build puppet module.
I just need to install package and have only one stupid integration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants