Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dogapi hungs? #66

Closed
takus opened this issue May 10, 2015 · 5 comments
Closed

dogapi hungs? #66

takus opened this issue May 10, 2015 · 5 comments
Assignees

Comments

@takus
Copy link

takus commented May 10, 2015

I sends some metrics via fluent-plugin-dd, and sometimes its thread hungs. According to stacktrace, It seems that dogapi hungs in connecting https session. Any ideas to fix it?

https://gist.github.com/takus/26a73772c21ce2c6df98

@yannmh yannmh self-assigned this May 11, 2015
@yannmh
Copy link
Member

yannmh commented May 11, 2015

Hi @takus,

Thanks for reporting this issue.
By default, dogapi-rb has a 5 seconds timeout: beyond, the connection attempt should be dropped. I suspect that the issue could be related with fluent-plugin-dd as it possibly overrides this timeout value.

Would you be able to provide us more information on your dogapi-rb settings through this plugin ?

Thanks

@takus
Copy link
Author

takus commented May 12, 2015

Hi @yannmh,

Thanks for replying. I checked both source code, and default timeout of each lib is nil. I think the setting causes this issue. It seems that Dogapi::APIService has a 5 seconds timeout, but Dogapi::Client. Is that correct?

https://github.com/winebarrel/fluent-plugin-dd/blob/c141905d3ce203f8a6ef3a7800e2a5a559a499c1/lib/fluent/plugin/out_dd.rb#L13

def initialize(api_key, application_key=nil, host=nil, device=nil, silent=true, timeout=nil)

Thanks

@takus
Copy link
Author

takus commented May 12, 2015

The previous comment is wrong. Dogapi::Client uses Dogapi::v1::xxx in internal. But I noticed that #55 seems to be related to this issue. I'll try to upgrade to the latest version at first.

@yannmh
Copy link
Member

yannmh commented May 12, 2015

Great.
Please let me know if upgrading solved your issue.

@takus
Copy link
Author

takus commented May 20, 2015

@yannmh
It seems that upgrading solved the issue.
Thanks.

@takus takus closed this as completed May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants