Handle nil values from benchmarks in Capistrano #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
commented
Oct 1, 2018
| @@ -13,7 +13,9 @@ def self.reporter() | |||
|
|
|||
| def self.cap_version() | |||
| if @cap_version.nil? then | |||
| if Configuration.respond_to? :instance then | |||
| if !defined? Configuration | |||
There was a problem hiding this comment.
Configuration is not defined at test time, library would eventually fail with an empty version but for testing is ok.
This was referenced Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148
Even if I couldn't find the root cause of #148, the library should not YOLO-call
roundon the return value of the benchmark.This PRs adds a try/rescue around the call so that if the benchmark value can't be converted to Float it returns the string
n/a.Also added a test for the specific case.