Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If running in cpu-only mode, don't register malloc_hooks? #431

Open
NHDaly opened this issue Dec 13, 2024 · 0 comments
Open

If running in cpu-only mode, don't register malloc_hooks? #431

NHDaly opened this issue Dec 13, 2024 · 0 comments

Comments

@NHDaly
Copy link

NHDaly commented Dec 13, 2024

In our production deployment, we do not want to use malloc_hooks. We are swapping out our malloc implementation with a different library, and these do not play well together.

We are not using the allocation profiles anyway. We could run with --preset cpu_only, but it looks like the hooks are currently registered unconditionally:

register_hook<MallocxHook>();

Could we please change the malloc hooks to only be registered if allocation profiling is enabled? 🙏

Thank you!

CC: @d-netto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant