NoopSpan doesn't have additional methods

[funkjedi]

Integration works fine for web requests but my Laravel workers fail when running artisan queue:work

Symfony\Component\Debug\Exception\FatalThrowableError Call to undefined method OpenTracing\NoopSpan::setResource() 
    vendor/datadog/dd-trace/src/DDTrace/Integrations/PDO/PDOIntegration.php:42 PDO::DDTrace\Integrations\PDO\{closure}
    vendor/laravel/framework/src/Illuminate/Database/Connectors/Connector.php:68 Illuminate\Database\Connectors\Connector::createPdoConnection
    vendor/laravel/framework/src/Illuminate/Database/Connectors/Connector.php:44 Illuminate\Database\Connectors\Connector::createConnection
    vendor/laravel/framework/src/Illuminate/Database/Connectors/MySqlConnector.php:24 Illuminate\Database\Connectors\MySqlConnector::connect

The problem appears to be the tracer is trying to use NoopSpan which doesn't have the extra methods implemented in DDTrace\Span.

dd-trace-php/src/DDTrace/Tracer.php

Lines 97 to 99 in 690bd17

	if (!$this->config['enabled']) {
	return NoopSpan::create();
	}

There probably needs to be a OpenTracing\NoopSpan subclass in DDTrace that implements all the additional methods that have been added.

Temporarily worked around by registering the DDTrace service provider from my AppServiceProvider only when not on CLI.

/**
 * Register any application services.
 *
 * @return void
 */
public function register()
{
    if (extension_loaded('ddtrace') && php_sapi_name() !== 'cli') {
        $this->app->register(\DDTrace\Integrations\LaravelProvider::class);
    }

[labbati]

Hi @funkjedi, thanks for the issue. Working on it very soon!

[labbati]

Fixed by #141 currently in CR.

[labbati]

Hi @funkjedi, 0.4.2 has been released: https://github.com/DataDog/dd-trace-php/releases/tag/0.4.2
Can you please confirm that this release fixes your issue?
Thanks for the patience!

[alkin]

I am getting an error that may be related to this issue:

Call to undefined method OpenTracing\NoopSpan::setRawError()

Checking the code i found that the method is called in two integrations:

src/DDTrace/Integrations/Curl/CurlIntegration.php
src/DDTrace/Integrations/PDO/PDOIntegration.php

[labbati]

Hi @alkin , we are aware of the issue and we will be providing a fix in two steps:

• initially we are just returning a DDTrace version of NoopSpan which provides the required methods
• then we will refactor our integration with open tracing entirely relying on our classes (which will be compatible with open tracing though)
  Working on it today, for the first step, which will be enough to work around the issue, though.

[labbati]

Just to let you know, we just release 0.5.0 which fixes the issue reported here (we implemented our own NoopSpan as @funkjedi was suggesting). We will also go further soon and slightly refactor the way we integrate with OpenTracing.

If you have a moment and can confirm that this actually works for you it would be great.

Thanks for the patience.

[funkjedi]

So far so good.

[labbati]

Closing this issue as it seems to be resolved!