From 3597b5d8dc08210f5cf01ec89759fd9e00a21864 Mon Sep 17 00:00:00 2001 From: Alejandro Estringana Ruiz Date: Mon, 8 Jan 2024 12:22:55 +0100 Subject: [PATCH] Amend failing test --- appsec/src/helper/sampler.hpp | 1 - .../listeners/asm_features_listener_test.cpp | 10 ++++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/appsec/src/helper/sampler.hpp b/appsec/src/helper/sampler.hpp index 34aa6c92ff5..f87f452d07c 100644 --- a/appsec/src/helper/sampler.hpp +++ b/appsec/src/helper/sampler.hpp @@ -104,7 +104,6 @@ class sampler { void set_sampler_rate(double sampler_rate) { - sampler_rate = valid_sample_rate(sampler_rate); if (sampler_rate == sample_rate_) { diff --git a/appsec/tests/helper/remote_config/listeners/asm_features_listener_test.cpp b/appsec/tests/helper/remote_config/listeners/asm_features_listener_test.cpp index f5e5e21ad95..e75e177436c 100644 --- a/appsec/tests/helper/remote_config/listeners/asm_features_listener_test.cpp +++ b/appsec/tests/helper/remote_config/listeners/asm_features_listener_test.cpp @@ -364,16 +364,18 @@ TEST_F(RemoteConfigAsmFeaturesListenerTest, DynamicEnablementIsDisabled) TEST_F(RemoteConfigAsmFeaturesListenerTest, ApiSecurityIsDisabled) { + auto some_rate = 0.123; + service_config->set_request_sample_rate(some_rate); remote_config::asm_features_listener listener(service_config, true, false); - { // Api security value is stored regardless + { // Api security is not parsed if not enabled try { listener.on_update( get_config_with_status_and_sample_rate("true", 0.2)); } catch (remote_config::error_applying_config &error) { std::cout << error.what() << std::endl; } - EXPECT_EQ(0.2, service_config->get_request_sample_rate()); + EXPECT_EQ(some_rate, service_config->get_request_sample_rate()); EXPECT_EQ(enable_asm_status::ENABLED, service_config->get_asm_enabled_status()); } @@ -386,8 +388,8 @@ TEST_F(RemoteConfigAsmFeaturesListenerTest, ApiSecurityIsDisabled) } catch (remote_config::error_applying_config &error) { std::cout << error.what() << std::endl; } - EXPECT_EQ( - 0.2, service_config->get_request_sample_rate()); // same as before + EXPECT_EQ(some_rate, + service_config->get_request_sample_rate()); // same as before EXPECT_EQ(enable_asm_status::ENABLED, service_config->get_asm_enabled_status()); }