diff --git a/profiling/build.rs b/profiling/build.rs index 1baad70a33b..fcda2978a29 100644 --- a/profiling/build.rs +++ b/profiling/build.rs @@ -100,7 +100,7 @@ fn build_zend_php_ffis( "../zend_abstract_interface/sandbox/php8/sandbox.c" }; - // Profiling only needs config and its dependencies. + // Profiling only needs config, exceptions and its dependencies. let zai_c_files = [ "../zend_abstract_interface/config/config_decode.c", "../zend_abstract_interface/config/config_ini.c", diff --git a/profiling/src/php_ffi.h b/profiling/src/php_ffi.h index 93b17c627eb..c003c4fd323 100644 --- a/profiling/src/php_ffi.h +++ b/profiling/src/php_ffi.h @@ -18,6 +18,8 @@ // Profiling needs ZAI config for INI support. #include +// Exception profiling needs to get the message of the exception (and ZAI +// provides `zai_exception_message()`) #include // Used to communicate strings from C -> Rust. diff --git a/profiling/src/profiling/mod.rs b/profiling/src/profiling/mod.rs index feadf5a5da6..a7c1cc232d1 100644 --- a/profiling/src/profiling/mod.rs +++ b/profiling/src/profiling/mod.rs @@ -754,7 +754,7 @@ impl Profiler { labels.push(Label { key: "exception message", - value: LabelValue::Str(message.clone().into()), + value: LabelValue::Str(message.into()), }); let n_labels = labels.len();