diff --git a/.github/workflows/project.yml b/.github/workflows/project.yml index 74820a6c09a..9c59f9fcdac 100644 --- a/.github/workflows/project.yml +++ b/.github/workflows/project.yml @@ -53,6 +53,9 @@ jobs: integration-cypress: strategy: matrix: + # Important: This is outside the minimum supported version of dd-trace-js + # Node > 16 does not work with Cypress@6.7.0 (not even without our plugin) + # TODO: figure out what to do with this: we might have to deprecate support for cypress@6.7.0 version: [16, latest] # 6.7.0 is the minimum version we support cypress-version: [6.7.0, latest] diff --git a/integration-tests/cypress-config.json b/integration-tests/cypress-config.json index 3bd4dc31817..3ad19f9f90a 100644 --- a/integration-tests/cypress-config.json +++ b/integration-tests/cypress-config.json @@ -4,5 +4,6 @@ "pluginsFile": "cypress/plugins-old/index.js", "supportFile": "cypress/support/e2e.js", "integrationFolder": "cypress/e2e", - "defaultCommandTimeout": 100 + "defaultCommandTimeout": 100, + "nodeVersion": "system" } diff --git a/integration-tests/cypress/cypress.spec.js b/integration-tests/cypress/cypress.spec.js index ad297913ef8..85381f41e2e 100644 --- a/integration-tests/cypress/cypress.spec.js +++ b/integration-tests/cypress/cypress.spec.js @@ -30,6 +30,7 @@ const { } = require('../../packages/dd-trace/src/plugins/util/test') const { ERROR_MESSAGE } = require('../../packages/dd-trace/src/constants') const semver = require('semver') +const { NODE_MAJOR } = require('../../version') const version = process.env.CYPRESS_VERSION const hookFile = 'dd-trace/loader-hook.mjs' @@ -56,6 +57,9 @@ moduleType.forEach(({ if (type === 'esm' && semver.satisfies(version, '<10.0.0')) { return } + if (version === '6.7.0' && NODE_MAJOR > 16) { + return + } describe(`cypress@${version} ${type}`, function () { this.retries(2) this.timeout(60000)