Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: mark top level spans #782

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Conversation

piochelepiotr
Copy link
Collaborator

Set top level flag directly in tracer. Not in agent.
That way, we don't need to have access to the whole chunk in the agent.

@piochelepiotr piochelepiotr marked this pull request as ready for review December 7, 2020 21:08
@gbbr gbbr changed the title Set top level metric ddtrace/tracer: mark top level spans Dec 8, 2020
ddtrace/tracer/span.go Outdated Show resolved Hide resolved
ddtrace/tracer/span.go Outdated Show resolved Hide resolved
ddtrace/tracer/span.go Outdated Show resolved Hide resolved
ddtrace/tracer/tracer_test.go Show resolved Hide resolved
ddtrace/tracer/span.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants