Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for go-pg integration #681

Closed
patriczek opened this issue Jun 9, 2020 · 7 comments
Closed

Add support for go-pg integration #681

patriczek opened this issue Jun 9, 2020 · 7 comments
Labels
apm:ecosystem contrib/* related feature requests or bugs proposal more in depth change that requires full team approval

Comments

@patriczek
Copy link

Hi, i would like to add new integration for go-pg orm.

https://github.com/go-pg/pg

@gbbr gbbr added apm:ecosystem contrib/* related feature requests or bugs proposal more in depth change that requires full team approval labels Jun 10, 2020
@gbbr
Copy link
Contributor

gbbr commented Jun 10, 2020

Hi 👋 Thanks for the offer. I don't see why not! Before starting work, can we go over how we will approach the implementation here? Does this library provide any hooks for tracing?

@patriczek
Copy link
Author

patriczek commented Jun 10, 2020

Hi,
yes ofc they provide hooks, i have some preview here:
patriczek@11a3cc4

For now there aren't completed tests and some TODOs

@gbbr
Copy link
Contributor

gbbr commented Jun 10, 2020

I see! Thanks for sharing that! That's no problem at all. The approach looks good to me. You can open a PR if you like. However, I'd leave Wrap out of it. Providing only the Hook should be enough.

@patriczek
Copy link
Author

Ok however before PR i would like to complete TODOs and rename Wrap to Hook

@patriczek
Copy link
Author

Sorry for delay, can you please check my MR: #686. Probably there must be some changes.

@gbbr
Copy link
Contributor

gbbr commented Jul 1, 2020

Yup. But please have a green CI.

@patriczek
Copy link
Author

I don't see which errors are in CI

@gbbr gbbr closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs proposal more in depth change that requires full team approval
Projects
None yet
Development

No branches or pull requests

2 participants