diff --git a/contrib/gin-gonic/gin/gintrace_test.go b/contrib/gin-gonic/gin/gintrace_test.go index 38b104bb29..e3239b21ba 100644 --- a/contrib/gin-gonic/gin/gintrace_test.go +++ b/contrib/gin-gonic/gin/gintrace_test.go @@ -76,7 +76,7 @@ func TestTrace200(t *testing.T) { assert.Equal("http.request", span.OperationName()) assert.Equal(ext.SpanTypeWeb, span.Tag(ext.SpanType)) assert.Equal("foobar", span.Tag(ext.ServiceName)) - assert.Contains(span.Tag(ext.ResourceName), "gin.TestTrace200") + assert.Contains(span.Tag(ext.ResourceName), "GET /user/:id") assert.Equal("200", span.Tag(ext.HTTPCode)) assert.Equal("GET", span.Tag(ext.HTTPMethod)) // TODO(x) would be much nicer to have "/user/:id" here @@ -311,7 +311,7 @@ func TestResourceNamerSettings(t *testing.T) { router.GET("/test", func(c *gin.Context) { span, ok := tracer.SpanFromContext(c.Request.Context()) assert.True(ok) - assert.Equal(span.(mocktracer.Span).Tag(ext.ResourceName), c.HandlerName()) + assert.Equal(span.(mocktracer.Span).Tag(ext.ResourceName), "GET /test") }) r := httptest.NewRequest("GET", "/test", nil) diff --git a/contrib/gin-gonic/gin/option.go b/contrib/gin-gonic/gin/option.go index c9fc37c23e..853fcf5944 100644 --- a/contrib/gin-gonic/gin/option.go +++ b/contrib/gin-gonic/gin/option.go @@ -59,5 +59,5 @@ func WithResourceNamer(namer func(c *gin.Context) string) Option { } func defaultResourceNamer(c *gin.Context) string { - return c.HandlerName() + return c.Request.Method + " " + c.FullPath() } diff --git a/internal/version/version.go b/internal/version/version.go index 9f39fb0948..02181bb15a 100644 --- a/internal/version/version.go +++ b/internal/version/version.go @@ -8,4 +8,4 @@ package version // Tag specifies the current release tag. It needs to be manually // updated. A test checks that the value of Tag never points to a // git tag that is older than HEAD. -const Tag = "v1.20.1" +const Tag = "v1.21.0"