From 4ab63dd574e534bffdba4e9d256c9cfd84f70d96 Mon Sep 17 00:00:00 2001
From: Dmytro Yurchenko <dmytro.yurchenko@datadoghq.com>
Date: Wed, 17 Jul 2024 18:21:47 +0200
Subject: [PATCH] ci: Add instruction for updating CI images

---
 .gitlab/macrobenchmarks.yml | 58 ++++++++++++++++++++++---------------
 1 file changed, 34 insertions(+), 24 deletions(-)

diff --git a/.gitlab/macrobenchmarks.yml b/.gitlab/macrobenchmarks.yml
index 90d911da98..d3056dea76 100644
--- a/.gitlab/macrobenchmarks.yml
+++ b/.gitlab/macrobenchmarks.yml
@@ -38,122 +38,132 @@ variables:
   # benchmarks get changed to run on every PR)
   allow_failure: true
 
-go122-baseline:
+
+#
+# !! Please read BEFORE updating Go versions
+#
+# In order to update Go version, you also need to rebuild benchmarks Docker image:
+# 1. Update version in Dockerfile https://github.com/DataDog/benchmarking-platform/blob/go/go-prof-app/container/Dockerfile#L5
+# 2. Rebuild image in Gitlab CI (build-images CI job)
+#
+
+.go121-benchmarks:
   extends: .benchmarks
+  variables:
+    GO_VERSION: "1.21.12"
+
+.go122-benchmarks:
+  extends: .benchmarks
+  variables:
+    GO_VERSION: "1.22.5"
+
+#
+# Specific macrobenchmark configurations are below
+
+go122-baseline:
+  extends: .go122-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "false"
     ENABLE_PROFILING: "false"
     ENABLE_APPSEC: "false"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.22.5"
 
 go122-only-trace:
-  extends: .benchmarks
+  extends: .go122-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "true"
     ENABLE_PROFILING: "false"
     ENABLE_APPSEC: "false"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.22.5"
 
 go122-only-profile:
-  extends: .benchmarks
+  extends: .go122-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "false"
     ENABLE_PROFILING: "true"
     ENABLE_APPSEC: "false"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.22.5"
 
 go122-profile-trace:
-  extends: .benchmarks
+  extends: .go122-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "true"
     ENABLE_PROFILING: "true"
     ENABLE_APPSEC: "false"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.22.5"
 
 go122-trace-asm:
-  extends: .benchmarks
+  extends: .go122-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "true"
     ENABLE_PROFILING: "false"
     ENABLE_APPSEC: "true"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.22.5"
 
 go122-profile-trace-asm:
-  extends: .benchmarks
+  extends: .go122-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "true"
     ENABLE_PROFILING: "true"
     ENABLE_APPSEC: "true"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.22.5"
 
 go121-baseline:
-  extends: .benchmarks
+  extends: .go121-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "false"
     ENABLE_PROFILING: "false"
     ENABLE_APPSEC: "false"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.21.12"
 
 go121-only-trace:
-  extends: .benchmarks
+  extends: .go121-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "true"
     ENABLE_PROFILING: "false"
     ENABLE_APPSEC: "false"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.21.12"
 
 go121-only-profile:
-  extends: .benchmarks
+  extends: .go121-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "false"
     ENABLE_PROFILING: "true"
     ENABLE_APPSEC: "false"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.21.12"
 
 go121-profile-trace:
-  extends: .benchmarks
+  extends: .go121-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "true"
     ENABLE_PROFILING: "true"
     ENABLE_APPSEC: "false"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.21.12"
 
 go121-trace-asm:
-  extends: .benchmarks
+  extends: .go121-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "true"
     ENABLE_PROFILING: "false"
     ENABLE_APPSEC: "true"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.21.12"
 
 go121-profile-trace-asm:
-  extends: .benchmarks
+  extends: .go121-benchmarks
   variables:
     ENABLE_DDPROF: "false"
     ENABLE_TRACING: "true"
     ENABLE_PROFILING: "true"
     ENABLE_APPSEC: "true"
     DD_PROFILING_EXECUTION_TRACE_ENABLED: "false"
-    GO_VERSION: "1.21.12"