From 180b7739f8b2bbef442c4a6ff5fd3468255fc8ab Mon Sep 17 00:00:00 2001 From: Kyle Nusbaum Date: Mon, 16 Mar 2020 15:32:07 -0500 Subject: [PATCH] Remove unnecessary test --- ddtrace/tracer/tracer_test.go | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/ddtrace/tracer/tracer_test.go b/ddtrace/tracer/tracer_test.go index fdb9788ad3..b9bfd9a310 100644 --- a/ddtrace/tracer/tracer_test.go +++ b/ddtrace/tracer/tracer_test.go @@ -1068,22 +1068,6 @@ func TestVersion(t *testing.T) { _, ok := sp.Meta[ext.Version] assert.False(ok) }) - - t.Run("unset3", func(t *testing.T) { - os.Setenv("DD_SERVICE", "servenv") - defer os.Unsetenv("DD_SERVICE") - os.Setenv("DD_VERSION", "1.2.3") - defer os.Unsetenv("DD_VERSION") - - // WithGlobalTag sets ext.ServiceName on each individual span, so version will not be set. - tracer, _, _, stop := startTestTracer(t, WithGlobalTag(ext.ServiceName, "otherservenv")) - defer stop() - - assert := assert.New(t) - sp := tracer.StartSpan("http.request").(*span) - _, ok := sp.Meta[ext.Version] - assert.False(ok) - }) } // BenchmarkConcurrentTracing tests the performance of spawning a lot of