RUMM-2256 Fix Mac Catalyst compatibility in 1.11.0
#894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appears that `https://github.com/cbf1/bitrise-step-xcodebuild` no longer supports recent version(s) of `xcodebuild` and it errors silently on failing to interpret the `-destination` flag. I'm replacing it with plain `script` step as we're not really interested in getting more from this step than sanity check (build). It also means no dependency on 3rd party CI step (`cbf1/bitrise-step-xcodebuild`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🐞 Solves #892 revealing Mac Catalyst compatibility broken in
1.11.0.It was broken incidentally in #764 and because we lost observability on it in smoke tests, the problem was not alerted.
How?
First, I fixed the Mac Catalyst compatibility smoke test in
bitrise.yml. This test started failing silently (we don't know when). Because it was based on 3rd-partycbf1/bitrise-step-xcodebuildinstead of tracing the problem, I replace it with plain 1st-partyscript. We now runxcodebuilddirectly with-euxo pipefailflags to fail the job on any issues.Second, I fixed the actual implementation by bringing back
#if targetEnvironment(macCatalyst)checks incidentally removed in #764.Review checklist
Custom CI job configuration (optional)