Allow manually tracked resources to detect first party hosts #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzybinary
force-pushed
the
jward/RUMM-2157-first-party-hosts
branch
from
976d24d to
afc8c1c
Compare
maxep
reviewed
May 4, 2022
|
Yeah that would simplify things. I'll give it a shot. |
|
@maxep Updated, let me know if this is what you meant. |
maxep
reviewed
May 4, 2022
|
Yes, exactly! I left another /nit Also, could you rebase on |
maxep
approved these changes
May 4, 2022
First party hosts set by `trackUrlSession` only works for automatically instrumented URLSessions. This allows manual calls to startResourceLoading and stopResourceLoading to detect first party host calls as well.
Instead, use the firstPartyURLsFilter on the dependencies to set isFirstPartyResource as we're writing the resource.
fuzzybinary
force-pushed
the
jward/RUMM-2157-first-party-hosts
branch
from
62c429d to
e3dad80
Compare
Checking first party resource a the last possible minute, avoiding passing it through multiple scopes.
|
@maxep Moved it up one more level. |
Co-authored-by: Maxime Epain <maxime.epain@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
First party hosts set by
trackUrlSessiononly works for automatically instrumented URLSessions. This allows manual calls to startResourceLoading and stopResourceLoading to detect first party host calls as well.How?
Not sure if this is the approach we want to take, but it made sense to me. I'm pulling the configuration onto the RUM feature configuration, then using that in the dependency configuration for the application scope to create the same Filter object that the URLSessionDelegate uses.
Review checklist
Custom CI job configuration (optional)