Fix RUM events to support sending correctly configured source value
#832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncreated
approved these changes
Apr 28, 2022
Comment on lines
233
to
235
| static func mockAnySource() -> String { | ||
| return ["ios", "android", "browser", "ios", "react-native", "flutter"].randomElement()! | ||
| } |
There was a problem hiding this comment.
This is rather RUM-specific mock than Foundation mock, hence FoundationMocks is IMO not the best place for this. How about moving this next to existing RUMErrorEvent.Error.SourceType mock in RUMDataModelMocks.swift?
Following this segregation will pay off nicely when we'll be extracting modules for V2 (both in implementation and tests).
There was a problem hiding this comment.
Yeah, good call. I'll move it.
maxep
approved these changes
Apr 28, 2022
| func testGivenStartedView_whenCrossPlatformErrorIsAdded_itSendsCorrectErrorEvent() throws { | ||
| var currentTime: Date = .mockDecember15th2019At10AMUTC() | ||
|
|
||
| let scope: RUMViewScope = .mockWith(parent: parent, dependencies: dependencies) | ||
| let customSource = String.mockAnySource() | ||
| let expectedSource = RUMErrorEvent.Source.init(rawValue: customSource) |
There was a problem hiding this comment.
/nit
Suggested change
| let expectedSource = RUMErrorEvent.Source.init(rawValue: customSource) | |
| let expectedSource = RUMErrorEvent.Source(rawValue: customSource) |
There was a problem hiding this comment.
👍 Sometimes tab completion is not your friend, especially when switching languages :)
|
|
||
| XCTAssertTrue( | ||
| scope.process(command: RUMStartViewCommand.mockAny()) | ||
| ) | ||
|
|
||
| currentTime.addTimeInterval(1) | ||
|
|
||
| let customSourceType = String.mockAnySource() | ||
| let expectedSourceType = RUMErrorSourceType.init(rawValue: customSourceType) |
There was a problem hiding this comment.
/nit
Suggested change
| let expectedSourceType = RUMErrorSourceType.init(rawValue: customSourceType) | |
| let expectedSourceType = RUMErrorSourceType(rawValue: customSourceType) |
Fixes RUMM-2162 PR Feedback Move source mocking, fix use of .init over constructors.
fuzzybinary
force-pushed
the
jward/RUMM-2162-custom-source
branch
from
326d6df to
ae560c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
The React Native and Flutter SDKs set the
_dd.sourceadditional property to have that change thesourceproperty of events. However, all of the RUM events were still only even usingiosas the source. This should fix it so that, if a value is provided to the the_dd.sourceattribute map, that source is sent to RUMMFixes RUMM-2162
Review checklist
Custom CI job configuration (optional)