Release 1.7.2 #655
Merged
Release 1.7.2 #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncreated
commented
Nov 5, 2021
maxep
approved these changes
Nov 5, 2021
…LowPowerModeEnabled` We suspect an iOS 15 bug (ref.: https://openradar.appspot.com/FB9741207) which leads to rare `_os_unfair_lock_recursive_abort` crash when `processInfo.isLowPowerModeEnabled` is accessed directly in the notification handler. As a workaround, we defer its access to the next run loop where underlying lock should be already released. ref.: https://openradar.appspot.com/FB9741207
ncreated
force-pushed
the
hotfix/1.7.2
branch
from
3c13637 to
ded02d8
Compare
ncreated
force-pushed
the
hotfix/1.7.2
branch
from
ded02d8 to
15bb4f4
Compare
ncreated
force-pushed
the
hotfix/1.7.2
branch
from
15bb4f4 to
1b61791
Compare
# Conflicts: # DatadogSDK.podspec # DatadogSDKAlamofireExtension.podspec # DatadogSDKCrashReporting.podspec # DatadogSDKObjc.podspec # Sources/Datadog/Versioning.swift
buranmert
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR ships second hotfix for #609 by adding a workaround to potential iOS 15 issue.
How?
We suspect that accessing
processInfo.isLowPowerModeEnabledfrom pendingNSProcessInfoPowerStateDidChangenotification block leads to a deadlock on the main thread. As a workaround, we read iLPME value from the next run loop, where all underlying locks should already be released.I reported this issue to Apple: https://openradar.appspot.com/FB9741207
💡 This branch includes version bump to
1.7.2, but it's not visible in diff because I had to resolve conflict with the main branch (it conflicts becase we made1.8.0-beta1release after1.7.0). I also cherry picked recent fixes to release automation, so we can deploy this hotfix smoothly. If approved, I will put the release tag on 950b087.Review checklist