RUMM-1596 Fix issue with truncated stack traces not being displayed in Crash Reporting #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mark will be soon added by the ET frontend.
ncreated
changed the title
buranmert
approved these changes
Oct 15, 2021
Datadog/Example/Scenarios/CrashReporting/CrashReporting/CrashReportingViewController.swift
Show resolved
Hide resolved
ncreated
deleted the
ncreated/RUMM-1596-recursive-call-crash-symbolication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🐞 This PR fixes a bug with the crash reports containing a very long stack traces not being rendered properly by our frontend. This situation may correspond to crashes due to segmentation fault on infinite recursive call. In such case, we truncate the stack trace SDK-side by inserting
...mark. This is to ensure it doesn't exceed our ingestion limits.How?
Problem was that our SCI BE was failing to parse the stack trace due to
...truncation mark. In result, RUM Error was displayed, but it had no associated stack:The fix was discussed with ET team and they will (
ET-1602) insert this mark on the frontend-side when displaying the error. A counterpart work on our side is to remove the...mark from the stack, which is done in this PR.By removing truncation mark, the stack trace is rendered properly:
As an enhancement, I added "Infinite recursive call" button to our crash debugging tool:
Review checklist