Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-1530 Add Datadog.isInitialized variable #566

Merged
merged 2 commits into from
Aug 20, 2021
Merged

RUMM-1530 Add Datadog.isInitialized variable #566

merged 2 commits into from
Aug 20, 2021

Conversation

maxep
Copy link
Member

@maxep maxep commented Aug 18, 2021

What and why?

The public interface lacks a way of checking the SDK initialized state.

How?

A static variable isInitialized of the Datadog configuration class checks the internal instance availability.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@maxep maxep requested a review from ncreated August 18, 2021 14:24
@maxep maxep requested a review from a team as a code owner August 18, 2021 14:24
buranmert
buranmert suggested changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@buranmert buranmert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might break old Xcodes, but otherwise looks good 👍

Sources/Datadog/Datadog.swift Outdated Show resolved Hide resolved
ncreated
ncreated approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@ncreated ncreated added the needs-docs To mark PRs which need documentation update label Aug 18, 2021
xgouchet
xgouchet reviewed Aug 19, 2021
View reviewed changes
Copy link
Member

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxep maxep merged commit 8b3a8ed into master Aug 20, 2021
@maxep maxep deleted the maxep/RUMM-1530-add-init-check branch August 20, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgouchet xgouchet xgouchet left review comments

@ncreated ncreated ncreated approved these changes

@buranmert buranmert buranmert approved these changes

Assignees

@maxep maxep

Labels
needs-docs To mark PRs which need documentation update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxep @xgouchet @buranmert @ncreated