RUMM-1204 Linter not run for carthage builds #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buranmert
force-pushed
the
buranmert/RUMM-1204-no-linter-for-carthage
branch
4 times, most recently
from
72f0621 to
afa856c
Compare
|
I succeeded to fail in CI ✅ |
ncreated
requested changes
Mar 29, 2021
There was a problem hiding this comment.
Using $CARTHAGE == YES to exclude linter for Carthage builds looks good 👌, but the changes made to bitrise.yml introduce very odd setup:
- the
run_unit_testsstep may fail due to linter issue in SDK code or tests, - the
run_unit_testsstep may fail due to linter issue in other tools code or tests (e.g. bad formatting inapi-surfacetests), - as we retry
run_unit_testsstep upon failure, it will be run twice on linter issue.
If we want to run linter only once on CI, this should be run as part of run_linter step, not run_unit_tests. Excluding linter from run_unit_tests sounds OK, but in this PR we're removing the entire run_linter.
bitrise.yml
Outdated
Comment on lines
41
to
55
| - swiftlint@0.8.0: | ||
| title: Lint Sources/* | ||
| inputs: | ||
| - strict: 'yes' | ||
| - lint_config_file: "$BITRISE_SOURCE_DIR/tools/lint/sources.swiftlint.yml" | ||
| - linting_path: "$BITRISE_SOURCE_DIR" | ||
| - reporter: emoji | ||
| - swiftlint@0.8.0: | ||
| title: Lint Tests/* | ||
| is_always_run: true | ||
| inputs: | ||
| - strict: 'yes' | ||
| - linting_path: "$BITRISE_SOURCE_DIR" | ||
| - lint_config_file: "$BITRISE_SOURCE_DIR/tools/lint/tests.swiftlint.yml" | ||
| - reporter: emoji |
There was a problem hiding this comment.
Those steps were linting more than SDK code, see linter configuration:
# tools/lint/sources.swiftlint.yml:
- instrumented-tests/http-server-mock/Sources
- tools/api-surface/Sources
- tools/api-surface/Fixtures/Sources
- tools/rum-models-generator/Sources
- tools/rum-models-generator/Tests/rum-models-generator-coreTests/Fixtures/Output # lint generation fixture
- dependency-manager-tests/carthage/CTProject
- dependency-manager-tests/cocoapods/CPProject
- dependency-manager-tests/spm/SPMProject
# tools/lint/tests.swiftlint.yml:
- instrumented-tests/http-server-mock/Tests
- tools/api-surface/Tests
- tools/rum-models-generator/Tests
- dependency-manager-tests/carthage/CTProjectTests
- dependency-manager-tests/carthage/CTProjectUITests
- dependency-manager-tests/cocoapods/CTProjectTests
- dependency-manager-tests/cocoapods/CTProjectUITests
- dependency-manager-tests/spm/SPMProjectTests
- dependency-manager-tests/spm/SPMProjectUITestsNow, these sources are lint as part of "Run unit tests for Datadog - iOS Simulator" which is wrong (we shouldn't fail SDK tests due to linter issue in rum-models-generator tool).
buranmert
force-pushed
the
buranmert/RUMM-1204-no-linter-for-carthage
branch
from
a52d30d to
d9b5d2c
Compare
If CARTHAGE flag is set for xcodebuild, build phase is skipped
buranmert
force-pushed
the
buranmert/RUMM-1204-no-linter-for-carthage
branch
from
d9b5d2c to
807ca7c
Compare
ncreated
approved these changes
Mar 30, 2021
ncreated
changed the base branch from
master
to
ncreated/RUMM-1222-enforce-up-to-date-version-of-swiftlint
ncreated
merged commit 176aeb0
into
ncreated/RUMM-1222-enforce-up-to-date-version-of-swiftlint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Datadog.xcodeprojhasRun linterbuild phase.Our SPM&cocoapods users don't see
xcodeprojbut our carthage users build the framework from it.They don't need to lint our framework's source.
How?
Skip linting for
carthagecarthagepassesCARTHAGE=YESflag toxcodebuild, ourRun linterbuild phase checks this flag and it skips linting forcarthagebuilds.Review checklist