Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to provide an HTTP proxy or custom OkHttpBuilder / factory #592

Closed
ruXlab opened this issue May 5, 2021 · 6 comments · Fixed by #687
Closed

Option to provide an HTTP proxy or custom OkHttpBuilder / factory #592

ruXlab opened this issue May 5, 2021 · 6 comments · Fixed by #687
Assignees
Labels
enhancement New feature or request

Comments

@ruXlab
Copy link

ruXlab commented May 5, 2021

Hello Datadog team

Could you please provide an option to set HTTP proxy? Devices in our organisation can't access the Internet directly.

Is your feature request related to a problem? Please describe.
Our Android devices don't have direct access to the Internet, all applications must use HTTP proxy

Describe the solution you'd like
Please provide an option to supply a custom OkHttpClient or proxy configuration settings.

Describe alternatives you've considered
There are no alternatives

@ruXlab ruXlab added the enhancement New feature or request label May 5, 2021
@xgouchet
Copy link
Member

xgouchet commented May 6, 2021

Hi @ruXlab,
Thanks for reporting this issue, we're going to look into this feature request.
In the meantime, is there a way to setup the Proxy on the device level, to apply this globally ?

@xgouchet xgouchet self-assigned this May 6, 2021
@ruXlab
Copy link
Author

ruXlab commented May 10, 2021

Hello @xgouchet
Unfortunately, it won't be possible - each eligible app is aware of the proxy details but we can't set them system-wide.

Thanks

@trymnilsen
Copy link

Are you open for external contributions on this? We are also looking at using a proxy for our project and could be willing develop and share this.

@ruXlab
Copy link
Author

ruXlab commented Jun 21, 2021

I ended up forking project locally and adding okHttpBuilder to Configuration.Core and DatadogConfig.CoreConfig, changing few relevant methods, namely setupOkHttpClient and adding setOkHttpBuilder method for Configuration.Builder.

@xgouchet
Copy link
Member

xgouchet commented Jul 6, 2021

Hi @trymnilsen , we added this topic in our backlog and we have a bunch of constraints, but thanks for offering to contribute. We'll try and have this done as soon as possible

@trymnilsen
Copy link

Great, thanks for the response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants