Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd-sdk-android-okhttp artifact explicitly mentions io.opentracing.Span in the api, but does not declare the dep in the maven/gradle metadata #2486

Open
yogurtearl opened this issue Jan 16, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@yogurtearl
Copy link

Describe the bug

io.opentracing.Span is in the API of dd-sdk-android-okhttp, see here:

public static final fun parentSpan (Lokhttp3/Request$Builder;Lio/opentracing/Span;)Lokhttp3/Request$Builder;

but the pom/module file doesn't mention io.opentracing:opentracing-api:
see https://repo1.maven.org/maven2/com/datadoghq/dd-sdk-android-okhttp/2.17.0/dd-sdk-android-okhttp-2.17.0.pom
and
see https://repo1.maven.org/maven2/com/datadoghq/dd-sdk-android-okhttp/2.17.0/dd-sdk-android-okhttp-2.17.0.module

Kotlin 2.1.0 is more picky about missing deps.

Reproduction steps

Use Kotlin 2.1.0, and use dd-sdk-android-okhttp

You will get an error like this:

Cannot access class 'io.opentracing.Span'. Check your module classpath for missing or conflicting dependencies.

Logcat logs

No response

Expected behavior

You should add api(libs.openTracingApi) here:

implementation(libs.kotlin)
implementation(libs.okHttp)
implementation(libs.androidXAnnotation)

Affected SDK versions

2.17.0

Latest working SDK version

🤷‍♂️

Did you confirm if the latest SDK version fixes the bug?

Yes

Kotlin / Java version

2.1.0

Gradle / AGP version

8.11, 8.7.3

Other dependencies versions

No response

Device Information

No response

Other relevant information

No response

@yogurtearl yogurtearl added the bug Something isn't working label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant