New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zookeeper check opens sockets without setting a timeout #310

Closed

xcolour opened this issue Dec 20, 2012 · 1 comment

Assignees

Labels

checks

Milestone

Contributor

xcolour commented Dec 20, 2012

python's default timeout is no timeout, so it needs to be set explicitly when creating a socket.

https://github.com/DataDog/dd-agent/blob/master/checks.d/zk.py#L41

so:

set a default timeout when the zookeeper check makes socket connections
for bonus points, make the timeout configurable in datadog.conf (customer request)

ghost assigned clofresh

Contributor

clofresh commented Dec 20, 2012

Ack, rookie mistake

clofresh closed this as completed in

604eeb1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment