[disk] backward compatibility with old Disk check #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degemer
force-pushed
the
quentin/disk-check-compatibility
branch
3 times, most recently
from
0cd5c81 to
1e4eee5
Compare
The new disk check was ignoring by default tmpfs disks and some others, breaking compatibility with the old check. It is fixed by filtering on device name (exclusion on '' and 'none') and total disk usage (!= 0), and setting all_partitions to True for psutil. The new all_partitions option will send metrics from the non excluded disks with 0 total disk usage.
degemer
force-pushed
the
quentin/disk-check-compatibility
branch
from
1e4eee5 to
c56015f
Compare
|
LGTM! |
remh
added a commit
that referenced
this pull request
Jun 17, 2015
[disk] backward compatibility with old Disk check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new disk check was ignoring by default tmpfs disks and some others,
breaking compatibility with the old check.
It is fixed by filtering on device name (exclusion on '' and 'none') and total
disk usage (!= 0), and setting all_partitions to True for psutil.
The new all_partitions option will send metrics from the non excluded disks
with 0 total disk usage.