[http_check] Fix status type err. in service check #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elafarge
changed the title
PyYaml was returning an int for the expected status code when "http_response_status_code: 200" (for instance) was used in the yaml config while a Regex (and therefore an string) is expected. Added a line to the http_check.yaml.conf.example file to document the possibility for the user to use a Regex if he wants to define a set of "CONNECTION_OK" HTTP status codes (and not only a single one).
LeoCavaille
force-pushed
the
etienne/http_check_status_config_fix
branch
from
e480a15 to
cbd9e11
Compare
|
Thanks for the merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyYaml was returning an int for the expected status code when
"http_response_status_code: 200" (for instance) was used in the yaml
config while a Regex (and therefore an string) is expected. I added a
cast to avoid that from happening again. I also added some doc to tell
our customers about the possibility to use a Regex for this parameter.