Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP/TCP Check] Add support for custom tags #1642

Merged
merged 1 commit into from
May 28, 2015
Merged

[HTTP/TCP Check] Add support for custom tags #1642

merged 1 commit into from
May 28, 2015

Conversation

remh
Copy link

@remh remh commented May 26, 2015

And get rid of legacy ch…eck names

The old check names are currently transformed in the backend

cc: @conorbranagan

@conorbranagan
Copy link
Contributor

lgtm 👍

@LeoCavaille
Copy link
Member

@remh some tests in the CI are failing, could you have a look and try to run these tests locally?

@LeoCavaille LeoCavaille added this to the 5.4.0 milestone May 27, 2015
@remh
Copy link
Author

remh commented May 27, 2015

Yeah looks like there are more tests impacted by this change than the http check test, fixing it.

@remh remh closed this May 27, 2015
@remh remh reopened this May 27, 2015
[HTTP/TCP Check] Add support for custom tags and get rid of legacy ch…
5d99182 
…eck names

The old check names are currently transformed in the backend
@remh remh force-pushed the remh/network_check_tags branch from 7cf98ab to 5d99182 Compare May 28, 2015 20:22
@remh
Copy link
Author

remh commented May 28, 2015

Build is passing, merging.

remh pushed a commit that referenced this pull request May 28, 2015
Merge pull request #1642 from DataDog/remh/network_check_tags
8f69fd8 
[HTTP/TCP Check] Add support for custom tags
@remh remh merged commit 8f69fd8 into master May 28, 2015
@yannmh yannmh mentioned this pull request Jun 4, 2015
Closed
@remh remh deleted the remh/network_check_tags branch June 10, 2015 16:32
yannmh added a commit that referenced this pull request Aug 3, 2015
@yannmh
[network] normalize instance_name tags
63ef7d3 
Instance name used to be a part of the check name and hence normalized
on the agent before being sent to Datadog.
As part of changes #1642 which introduced support for custom tags,
'instance_name' is now sent as a proper tag. Normalize it, to avoid mismatch and
backward incompatiblity.

Fix #1796.
@yannmh yannmh mentioned this pull request Aug 3, 2015
Merged
yannmh added a commit that referenced this pull request Aug 6, 2015
@yannmh
[network] normalize instance_name tags
138b88e 
Instance name used to be a part of the check name and hence normalized
on the agent before being sent to Datadog.
As part of changes #1642 which introduced support for custom tags,
'instance_name' is now sent as a proper tag. Normalize it, to avoid mismatch and
backward incompatiblity.

Fix #1796.
@VynceMontgomery
Copy link

any progress here?

@remh
Copy link
Author

remh commented Sep 9, 2015

@VynceMontgomery this was released with Agent 5.4.0 https://github.com/DataDog/dd-agent/blob/master/CHANGELOG.md#540--06-16-2015

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5d99182 on remh/network_check_tags into ** on master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@remh remh

Labels
checks feature
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@remh @conorbranagan @LeoCavaille @VynceMontgomery @coveralls