[sqlserver] properly close cursor, avoid leaks #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
LeoCavaille
force-pushed
the
leo/sqlserver
branch
from
d809e5b to
e8547ce
Compare
We saw memory leak issues with that check. It could have been caused by two different things: * The fact that we are not closing cursors properly, and therefore not freeing properly the recordsets loaded in them * We instantiated wrongly two different cursors in the main check loop letting one leak...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw memory leak issues with that check. It could have been caused by
two different things:
freeing properly the recordsets loaded in them
letting one leak...