send fraction metrics as floats + cleaning #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
changed the title
yannmh
force-pushed
the
yann/fix-sql-server-wrong-zeros
branch
from
20a23c4 to
d1a6202
Compare
|
lgtm |
remh
pushed a commit
that referenced
this pull request
May 14, 2015
send fraction metrics as floats + cleaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL fractional values represent ratios: it should be casted as
float(rather thanint) otherwise information is lost behind a rounded0int.Default metrics impacted:
Buffer cache hit ratioakasqlserver.buffer.cache_hit_ratioMore information:
http://blogs.msdn.com/b/psssql/archive/2013/09/23/interpreting-the-counter-values-from-sys-dm-os-performance-counters.aspx
cc @simnyc