Omit MAIN type from varnish metric names #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LeoCavaille Can you take a pass at it when working on the Varnish tests ? |
Test on 3.x and 4.x. Allows to test the different metrics and ensure non-regression.
LeoCavaille
force-pushed
the
varnish_name_fix
branch
from
f9fce63 to
dbf3a81
Compare
|
New tests work fine (apache failed, probably because I didn't rebase it). And Arthur's fix is working as expected. Thanks 👍 |
LeoCavaille
added a commit
that referenced
this pull request
Apr 14, 2015
Omit MAIN type from varnish metric names
|
Changes Unknown when pulling dbf3a81 on varnish_name_fix into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1459