Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[packaging] Deprecate old dd-agent, dd-forwarder & dogstatsd commands #1457

Merged
merged 2 commits into from
Apr 27, 2015
Merged

[packaging] Deprecate old dd-agent, dd-forwarder & dogstatsd commands #1457

merged 2 commits into from
Apr 27, 2015

Conversation

degemer
Copy link
Member

@degemer degemer commented Mar 23, 2015

And some pep8 cleaning.

@degemer degemer added this to the 5.4.0 milestone Mar 23, 2015
@LeoCavaille
Copy link
Member

Nice, sorry for misreading this at first.
Looks good to me, thanks for organizing the code and the commits properly! It was an easy read 💯

@degemer degemer self-assigned this Apr 1, 2015
@degemer
Copy link
Member Author

degemer commented Apr 1, 2015

Will rebase when 5.3 is out.

@degemer
[core] some pep8 & flake8 cleaning
3c6b638 
In agent.py, ddagent.py & dogstatsd.py
(remove unused import, enforce pep8 standards)
@degemer degemer force-pushed the quentin/deprecate-old-commands branch from c9ab701 to 57891f0 Compare April 14, 2015 22:17
@degemer degemer removed their assignment Apr 16, 2015
@LeoCavaille LeoCavaille self-assigned this Apr 27, 2015
LeoCavaille
LeoCavaille reviewed Apr 27, 2015
View reviewed changes
packaging/centos/datadog-agent.init
@@ -27,7 +27,7 @@ AGENTCONF="/etc/dd-agent/datadog.conf"
DOGSTATSDPATH="/opt/datadog-agent/agent/dogstatsd.py"
AGENTUSER="dd-agent"
PIDPATH="/var/run/dd-agent/"
FORWARDERPATH="/usr/bin/dd-forwarder"
FORWARDERPATH="/opt/datadog-agent/agent/ddagent.py"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure these scripts are made executable in our package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are already 755 in the repo, and are only copied during the build, and chown during the postinstall. They should stay a+x unless the build machine has a weird umask.

@LeoCavaille LeoCavaille assigned degemer and unassigned LeoCavaille Apr 27, 2015
@degemer
[packaging] deprecate use of old command tools
74b4269 
Remove use of /usr/bin/ in datadog-agent.init for centos and debian
@degemer degemer force-pushed the quentin/deprecate-old-commands branch from 57891f0 to 74b4269 Compare April 27, 2015 18:36
@degemer degemer removed their assignment Apr 27, 2015
@LeoCavaille
Copy link
Member

👍

LeoCavaille added a commit that referenced this pull request Apr 27, 2015
@LeoCavaille
Merge pull request #1457 from DataDog/quentin/deprecate-old-commands
9f3f26a 
[packaging] Deprecate old dd-agent, dd-forwarder & dogstatsd commands
@LeoCavaille LeoCavaille merged commit 9f3f26a into master Apr 27, 2015
@LeoCavaille LeoCavaille deleted the quentin/deprecate-old-commands branch April 27, 2015 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packaging resilience
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@degemer @LeoCavaille