[sqlserver] add command timeout, 5sec default #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -185,19 +186,21 @@ def get_cursor(self, instance): | |||
| try: | |||
| conn_str = self._conn_string(instance) | |||
| conn = adodbapi.connect(conn_str) | |||
| conn.CommandTimeout = int(instance.get('command_timeout', | |||
| self.DEFAULT_COMMAND_TIMEOUT)) | |||
There was a problem hiding this comment.
conn.CommandTimeout was set to 30seconds by default. As you are changing it to 5 seconds now, it may break some users configuration ? What do you think ?
|
Besides the concerns about potential backward incompatibilities, it looks good to me. Also it seems like you'd need to rebase your PR to be able to merge it properly |
degemer
force-pushed
the
quentin/fix-sql-server
branch
2 times, most recently
from
3a0a843 to
ec923d9
Compare
|
Thanks @yannmh, updated my PR. |
30s default, it shouldn't break any existing check as it is the default adodbapi timeout. [skip ci] (as it is a Windows check not tested)
degemer
force-pushed
the
quentin/fix-sql-server
branch
from
ec923d9 to
4cdb978
Compare
|
Thanks ! 👍 |
yannmh
added a commit
that referenced
this pull request
May 19, 2015
[sqlserver] add command timeout, 5sec default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a timeout for each SQL command (by default 5 sec), to fix #1247 .