[postgres] Always sent OK status, even with cached connection. #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were incorrectly only sending an OK status when a connection was first established. This means any monitors on this check would be in a NODATA state after the first run of the check. Now we'll send an OK once we have a working connection, even if the connection had to be reset.
|
According to the test Traceback (most recent call last):
File "/home/travis/build/DataDog/dd-agent/checks/__init__.py", line 543, in run
self.check(copy.deepcopy(instance))
File "/home/travis/build/DataDog/dd-agent/checks.d/postgres.py", line 410, in check
self.service_check(self.SERVICE_CHECK_NAME, AgentCheck.OK,
AttributeError: 'PostgreSql' object has no attribute 'SERVICE_CHECK_NAME'Can you fix ? Otherwise it looks good! |
LeoCavaille
changed the title
|
Should be good to go now, @remh. Thanks for the review! |
LeoCavaille
added a commit
that referenced
this pull request
Jan 2, 2015
[postgres] Always sent OK status, even with cached connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were incorrectly only sending an OK status when a connection was
first established. This means any monitors on this check would be in
a NODATA state after the first run of the check.
Now we'll send an OK once we have a working connection, even if the
connection had to be reset.
Also adds a message to the service check :)