Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service check for Gearman #1203

Merged
merged 2 commits into from
Dec 26, 2014
Merged

Add service check for Gearman #1203

merged 2 commits into from
Dec 26, 2014

Conversation

conorbranagan
Copy link
Contributor

No description provided.

LeoCavaille
LeoCavaille reviewed Nov 17, 2014
View reviewed changes
tests/test_gearman.py
except Exception:
pass
else:
raise Exception('Gearman instance was expected to fail.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use self.assertRaises

@LeoCavaille LeoCavaille added this to the 5.2.0 milestone Nov 17, 2014
@conorbranagan conorbranagan force-pushed the conor/gearman-service-check branch 2 times, most recently from eb2191f to 2c7e235 Compare November 17, 2014 13:46
@conorbranagan conorbranagan force-pushed the conor/gearman-service-check branch from 2c7e235 to 759ea9b Compare November 17, 2014 14:13
@LeoCavaille
Copy link
Member

Looks good to me, we don't have tags for the new service checks, but we didn't have anything per instance previously for metrics, so for now keeping it like that. We'll consider adding more tagging dimensions in the future for this check if need be.

@conorbranagan the Travis build error looks real:

test_service_checks (tests.test_gearman.GearmanTestCase) ... FAIL

======================================================================

FAIL: test_service_checks (tests.test_gearman.GearmanTestCase)

----------------------------------------------------------------------

Traceback (most recent call last):

File "/home/travis/build/DataDog/dd-agent/tests/test_gearman.py", line 41, in test_service_checks

self.assertRaises(self.check.check, Exception, config['instances'][1])

AssertionError: check not raised

@LeoCavaille LeoCavaille self-assigned this Dec 18, 2014
@LeoCavaille
Copy link
Member

Fixed the error above, merging now.

LeoCavaille added a commit that referenced this pull request Dec 26, 2014
@LeoCavaille
Merge pull request #1203 from DataDog/conor/gearman-service-check
b0a5ddb 
Add service check for Gearman
@LeoCavaille LeoCavaille merged commit b0a5ddb into master Dec 26, 2014
@LeoCavaille LeoCavaille deleted the conor/gearman-service-check branch December 26, 2014 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LeoCavaille LeoCavaille

Labels
3 - Done checks feature service checks
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@conorbranagan @LeoCavaille