new constant tags for statsd client #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm that py26 failure is not happening locally. looks like a set comprehension in mock. anyone else seen this? |
|
Thanks a lot @jofusa, it looks great. We'll review your PR really soon. Python 2.6 failure seems related with testing-cabal/mock#259. I'll make the necessary to fix it. |
remh
changed the title
|
#69 should fix Python 2.6 failure. Would you mind rebasing your PR on top of master please ? |
| @@ -113,7 +113,7 @@ def test_tags_and_samples(self): | |||
| def test_tags_and_samples(self): | |||
| for i in range(100): | |||
| self.statsd.gauge('gst', 23, tags=["sampled"], sample_rate=0.9) | |||
| t.assert_equal('gst:23|g|@0.9|#sampled') | |||
| t.assert_equal('gst:23|g|@0.9|#sampled,bar:baz,foo') | |||
There was a problem hiding this comment.
I don't think this test will pass, as not part of TestDogStatsdConstantTags class.
|
sounds great. will update tests |
johnistan
force-pushed
the
jdennison/client-level-tags
branch
from
353bc38 to
cb78472
Compare
|
rebased off master |
|
Thanks @jofusa ! It looks good to me. Let's merge it so it'll be part of the next release, v0.8.0, planned for next week. |
yannmh
added a commit
that referenced
this pull request
Jul 23, 2015
new constant tags for statsd client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a optional param (constant_tags) to the Dogstatsd client to append tags to every metrics call.
Useful for setting project wide tags like version.