fix http leak #272
Merged
fix http leak #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
reviewed
May 31, 2018
datadog/api/http_client.py
Outdated
| @@ -94,6 +94,8 @@ def request(cls, method, url, headers, params, data, timeout, proxies, verify, m | |||
| u"Datadog's usage. We recommand upgrading it ('pip install -U requests')." | |||
| u"If you need help or have any question, please contact support@datadoghq.com" | |||
| ) | |||
| finally: | |||
There was a problem hiding this comment.
Although this is 100% fine, I think I would prefer if we could use requests context manager for sessions...
we can basically wrap the entire method with:
with requests.Session() as s:
http_adapter = requests.adapters.HTTPAdapter(max_retries=max_retries)
s.mount('https://', http_adapter)
# REST OF METHOD...If you don't want to update that, just let me know as this is blatant nitpicking, and we can merge this as is!
There was a problem hiding this comment.
let me know what you think
|
btw, for future reference, with help I found one of the leaks was due to python/cpython#4587, because this would cause a warning of unclosed socket |
|
failures don't seem related to my change |
|
Thanks @thehesiod ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #271