UIE-206 app startup - unit tests #5254
Conversation
msilva-broad
force-pushed
the
msilva/UIE-206_startup-unit-tests_pt2
branch
from
cdbf54a to
467df78
Compare
msilva-broad
force-pushed
the
msilva/UIE-206_startup-unit-tests_pt2
branch
from
467df78 to
f9fbc04
Compare
msilva-broad
force-pushed
the
msilva/UIE-206_startup-unit-tests_pt2
branch
from
f9fbc04 to
a28f6a6
Compare
| const userManager: UserManager = new UserManager(getOidcConfig()); | ||
|
|
||
| const url = window.location.href; | ||
| const isSilent = window.location.pathname.startsWith('/redirect-from-oauth-silent'); | ||
| const url = getCurrentLocation().href; |
There was a problem hiding this comment.
window.location is difficult to mock in unit tests, and it's a global (awkward actor), which makes async unit tests unworkable. So this is being shifted to a thin wrapper that is much easier to mock.
| const rootElement = document.getElementById('root'); | ||
| const root = createRoot(rootElement!); | ||
| root.render(h(RedirectFromOAuth)); | ||
| }; |
There was a problem hiding this comment.
no functional change from old file location in src/auth, but wrapped in callable function.
| /** | ||
| * gets the current app window url location object | ||
| */ | ||
| export const getCurrentLocation = () => window.location; |
There was a problem hiding this comment.
window.location is difficult to mock in unit tests, and it's a global (awkward actor), which makes async unit tests unworkable. So this is being shifted to a thin wrapper that is much easier to mock.
| close: 'Close', | ||
| }, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
no functional change from old src/ location, but now in callable wrapper and light ts conversion
- added unit test coverage, made module scope logic into callable (and testable) functions. - shifted startup relatid modules to sub-folder. - light Typescript conversions.
- fixed missing act unit test warning
- minor cleanup
msilva-broad
force-pushed
the
msilva/UIE-206_startup-unit-tests_pt2
branch
from
3341420 to
5f6e882
Compare
|
Jira Ticket: https://broadworkbench.atlassian.net/browse/[Ticket #]
Summary of changes:
What
Why
Testing strategy