From 3c782d07b0b471e585915751c8194387cf20f5ef Mon Sep 17 00:00:00 2001 From: "Rebecca S. Asch" Date: Thu, 25 Apr 2019 16:37:44 -0400 Subject: [PATCH] changed 'task name' of workflow-level errors (#632) --- CHANGELOG.md | 3 +++ servers/cromwell/jobs/controllers/jobs_controller.py | 2 +- servers/cromwell/jobs/test/test_jobs_controller.py | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index da930db65..c28fbf9c6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,11 +2,14 @@ ## v0.7.2 Release Notes +### Improved the clarity of workflow-level errors. + ### Fixed incorrectly translated job attempt status from Cromwell backend. ### Fixed incorrect tooltip for standard out log. ### Added customized favicon. +>>>>>>> master ## v0.7.1 Release Notes diff --git a/servers/cromwell/jobs/controllers/jobs_controller.py b/servers/cromwell/jobs/controllers/jobs_controller.py index 3126898ca..92f8b9a22 100644 --- a/servers/cromwell/jobs/controllers/jobs_controller.py +++ b/servers/cromwell/jobs/controllers/jobs_controller.py @@ -221,7 +221,7 @@ def format_task_failure(task_name, metadata): def format_workflow_failure(failures): - return FailureMessage(task_name=failures.get('message'), + return FailureMessage('Workflow Error', failure=failures.get('causedBy')[0].get('message')) diff --git a/servers/cromwell/jobs/test/test_jobs_controller.py b/servers/cromwell/jobs/test/test_jobs_controller.py index bb013e78c..350c78633 100644 --- a/servers/cromwell/jobs/test/test_jobs_controller.py +++ b/servers/cromwell/jobs/test/test_jobs_controller.py @@ -438,7 +438,7 @@ def _request_callback(request, context): }, 'failures': [{ 'failure': 'Task test.analysis failed', - 'taskName': 'Workflow failed' + 'taskName': 'Workflow Error' }] } # yapf: disable self.assertDictEqual(response_data, expected_data)