-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub CI workflow selects dev
when building prod
branch
#5428
Comments
Index: .github/workflows/ci.yml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
--- a/.github/workflows/ci.yml (revision 3025429b8a6eb784dc7799340e4c775184109add)
+++ b/.github/workflows/ci.yml (date 1735347224051)
@@ -24,8 +24,9 @@
- name: 'Run unit tests and other checks'
run: |
- source environment
- _link dev
+ source environment # load global defaults
+ deployment=$(PYTHONPATH=src python scripts/check_branch.py --print)
+ _link $deployment
_refresh
make virtualenv and add support for |
For demo, show that
|
Partially demoed for pull builds but it remains to be demoed for push builds. |
From a recent promotion:
https://github.com/DataBiosphere/azul/actions/runs/5674220102/job/15377359216#step:4:3
This is why we detected #5426 only after the merge commit had already been pushed, and the build failed on GitLab. It did not fail on GitHub, but should have.
When building the
prod
branch, or a PR branch based on it, theprod
deployment should be selected.When building the
develop
branch, or a PR branch based on it, thedev
deployment should be selected, as is currently the case.The text was updated successfully, but these errors were encountered: