-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Galacticraft Sealed Space Block additions #2764
Comments
Am I presuming you have tested the config change? |
I actually have not yet, will do tomorrow. |
I take it back, didn't have a lot of time 8 hours ago, I'll get back to it later today (in a couple hours), look for the error and do some elaborate testing. EDIT: testing now, will comment behind config entry whether or not it works, then try to add them via ID (Galacticraft is supposed to tell you the block name then). |
The Not Sealed entries consist of:
And, additionally, Tconstruct Seared Glass. My guess: I forgot to add Seared Glass and all glass types with Meta ID don't work/syntax wrong (because I had to enter specific ID's for Insulating Glass and Structured Glass. Double-checking and testing again now, result expected within the next hour. EDIT: very certain now that it has something to do with Meta IDs (found a typo in the Seared Glass entry), however according to the Galacticraft wiki, the syntax should be right. Will give another update in an hour or so. After looking at the launcher log, it seems that the config doesn't like inline comments, which is why Insulating Glass and Structural Glass weren't recognized. Furthermore, asterix doesn't seem to be supported anymore. I'll just add everything by hand which should fix it all. |
Updated the gist, testing it now but I changed all... irregularities. EDIT: It works. EDIT2: Forgot chisel:glassdyedred and chisel:glassdyedgreen, added them now... I think I got them all. I'm done. |
Sweet thanks. I'll test it after work and merge it into the pack! Thanks for your work on this! |
Okay, so some stuff errors in the console which is fine. But we need to fix them for the next update. And go over it in more detail. I did a speed check over and missed the console errors so my bad but we're pushing 3.0.8 now so will be left behind |
Typo in mod name: ferdinandsflowers (I spelled it ferdinantsflowers) it's fixed now. |
is is possible to add RF tools Shield Blocks? |
Yes, if you can give me the ID. (Modname:blockname:meta) |
Going to close this one now. As we've added the main blocks. And I'm not happy to add RF Shields to the listing. You're forced to either use GC methods or build a base. Not cheat with a "magical" shield. 😄 |
Context
Galacticraft is supposed to add modifications of the Glass block as oxygen sealing blocks for the Oxygen Sealer (machine needed to fill rooms in space with oxygen). Chisel and Tinker's Construct glass blocks however are not detected automatically (all solid blocks count as sealing by default, Galacticraft tries to find glass-type blocks to add them to the list).
The Galacticraft Wiki mentions Tinker's Glass as example for a possibly wanted oxygen sealable block that is not detected automatically.
As a more personal note, Tinker's Construct Clear Glass is amongst the least-invading of all glass types and my favorite glass type for all glass buildings, especially glass domes/cubes. When using a Celestial Gateway for inter dimensional transport, an encasement made of Clear Glass also allows for the full beauty of the Celestial Gateway structure on minimal space.
A Clear Glass encasement is the perfect habitat for test subjects as they will feel like they are not imprisoned at all.
Also please remove Glass panes from the list, they even count if used in the ceiling/floor.
For the time being, the following near-invisible glass types work
Config/Script Details
The text was updated successfully, but these errors were encountered: