Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical alignment is not consistent across file types #260

Closed
ghost opened this issue Jan 17, 2016 · 2 comments
Closed

Vertical alignment is not consistent across file types #260

ghost opened this issue Jan 17, 2016 · 2 comments
Labels
enhancement Feature requests or suggested improvements. styling Questions and bugs related to package and user stylesheets.
Milestone

Comments

@ghost
Copy link

ghost commented Jan 17, 2016

I have my line-height fairly small in the tree view (20px), so this is more noticeable, I think, than the default layout. Notice that in the screenshots below, the .jsx file's text is bottom-aligned, while the .html file is properly middle-aligned. This roughly is caused by the different font-sizes of the icons.

image

image

@Alhadis
Copy link
Member

Alhadis commented Jan 19, 2016

Bit more to it than that, I'm afraid. There's actually a myriad of different font families, each of which are using noticeably different sizes for each glyph. The manually-set font-sizes are there to try normalising the size discrepancies between the different fonts.

So, short of manually pick through every font we're using and compile them into one neatly-organised superfont (which... I really wouldn't recommend for all the obvious reasons), we're reduced to this constant tennis match batting line-heights and font-sizes around. :-(

Alhadis added a commit that referenced this issue May 9, 2016
These typefaces have both been manually patched (had their alignment and
sizes normalised) so icon display is more consistent.

Resolves gh-260.
@Alhadis Alhadis mentioned this issue May 10, 2016
@Alhadis
Copy link
Member

Alhadis commented May 10, 2016

@zyklus This will be resolved in V2, hopefully. Please subscribe to the relevant task-list for updates.

And if you're unsure, yes, I really did go through 200+ icons individually and manually fit their alignments and sizes. I never claimed to be sane.

@Alhadis Alhadis closed this as completed May 10, 2016
@Alhadis Alhadis added enhancement Feature requests or suggested improvements. styling Questions and bugs related to package and user stylesheets. labels Oct 16, 2018
@Alhadis Alhadis added this to the 2.0.0 milestone Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or suggested improvements. styling Questions and bugs related to package and user stylesheets.
Projects
None yet
Development

No branches or pull requests

1 participant