From 22e15776a088fd2c3df3a61e1a57742b505f4347 Mon Sep 17 00:00:00 2001
From: Adela Homolova <adela.homolova@applifting.cz>
Date: Thu, 19 Sep 2019 15:07:28 +0200
Subject: [PATCH] fix: Allow user to add impact in object in dx config file

---
 src/scanner/Scanner.ts      | 9 ++++++++-
 src/scanner/ScannerUtils.ts | 1 -
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/scanner/Scanner.ts b/src/scanner/Scanner.ts
index d74a287c8..e5794e6e5 100644
--- a/src/scanner/Scanner.ts
+++ b/src/scanner/Scanner.ts
@@ -176,7 +176,14 @@ export class Scanner {
 
     const reportString = this.reporter.report(
       relevantPractices.map((p) => {
-        const impact = p.componentContext.configProvider.getOverridenPractice(p.practice.getMetadata().id);
+        const config = p.componentContext.configProvider.getOverridenPractice(p.practice.getMetadata().id);
+
+        let impact;
+        if (typeof config === 'string') {
+          impact = config;
+        } else if (config && 'impact' in config) {
+          impact = config.impact;
+        }
 
         return {
           practice: {
diff --git a/src/scanner/ScannerUtils.ts b/src/scanner/ScannerUtils.ts
index 2071989ee..1efdec3c1 100644
--- a/src/scanner/ScannerUtils.ts
+++ b/src/scanner/ScannerUtils.ts
@@ -60,7 +60,6 @@ export class ScannerUtils {
    */
   static isFulfilled(practice: IPracticeWithMetadata, evaluatedPractices: PracticeWithContext[]): boolean {
     const practiceMetadata = practice.getMetadata();
-    // console.log(practiceMetadata.name, 'name');
     if (!practiceMetadata.dependsOn) return true;
 
     for (const evaluation of _.keys(practiceMetadata.dependsOn)) {