Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null objects aren't cached #2833

Closed
alexandrevryghem opened this issue Feb 24, 2024 · 0 comments · Fixed by #3415
Closed

Null objects aren't cached #2833

alexandrevryghem opened this issue Feb 24, 2024 · 0 comments · Fixed by #3415
Assignees
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back performance / caching Related to performance, caching or embedded objects

Comments

@alexandrevryghem
Copy link
Member

Describe the bug
Objects aren't cached when they return null. This is visible for example on the search page, where thumbnails are requested again even tough they were embedded.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the search page and open the network tab (ensure there are items without thumbnails)
  2. You will see that even tough the results contain thumbnail: null an additional request is sent to retrieve who returns a 204

Expected behavior
No additional thumbnail requests should be sent

@alexandrevryghem alexandrevryghem added bug performance / caching Related to performance, caching or embedded objects needs triage New issue needs triage and/or scheduling claimed: Atmire Atmire team is working on this issue & will contribute back labels Feb 24, 2024
@alexandrevryghem alexandrevryghem self-assigned this Feb 24, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Feb 24, 2024
@tdonohue tdonohue removed the needs triage New issue needs triage and/or scheduling label Feb 26, 2024
@tdonohue tdonohue moved this to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Feb 26, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.x and 7.6.x Maintenance Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back performance / caching Related to performance, caching or embedded objects
Projects
2 participants