From 4c0b44241f79efe374f4b7b5432dfd7eeba16faa Mon Sep 17 00:00:00 2001 From: Dominic Saladin Date: Wed, 21 Dec 2022 21:17:44 +0100 Subject: [PATCH 1/3] Fix alFunctionItem conversion --- src/extension.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/extension.ts b/src/extension.ts index b19435d..1893654 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -96,7 +96,7 @@ export async function activate(context: vscode.ExtensionContext) { return; } - const quickPick = new QuickPickManagement(); + const quickPick = new QuickPickManagement(); const picked = quickPick.create(`Select event from ${ObjectType[alObject.objectType]} "${alObject.objectName}" to copy`); alObject = await reader.readAlObject(alObject); @@ -112,13 +112,13 @@ export async function activate(context: vscode.ExtensionContext) { ).forEach(alFunction => alFunctionItems.push(new ALFunctionItem(alObject!, alFunction, true))); quickPick.updateValue(alFunctionItems); - const alFunction = await picked; + const alFunctionItem = await picked; - if (!alFunction) { + if (!alFunctionItem) { return; } - await vscode.env.clipboard.writeText(alFunction.getEventSubscriberText(alObject)); + await vscode.env.clipboard.writeText(alFunctionItem.alFunction.getEventSubscriberText(alObject)); vscode.window.showInformationMessage("Copied to Clipboard!"); })); From 5b080cfe3645e0a33f722338ce059b6f6107b284 Mon Sep 17 00:00:00 2001 From: Dominic Saladin Date: Wed, 21 Dec 2022 21:20:10 +0100 Subject: [PATCH 2/3] Update to version 2.3.1 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 03a5aaf..2fcf9d7 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "name": "Dominic Saladin" }, "license": "MIT", - "version": "2.3.0", + "version": "2.3.1", "icon": "Images/ALObjectHelper_Small.png", "engines": { "vscode": "^1.63.0" From a917ac031d906d5ab8714d1f5c76e06dbbae61ac Mon Sep 17 00:00:00 2001 From: Dominic Saladin Date: Wed, 21 Dec 2022 21:24:10 +0100 Subject: [PATCH 3/3] Update changelog --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0cbd320..25fdafc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,10 @@ # Change Log All versions of AL Object Helper will be documented in this file. +## [2.3.1] - 2022-12-21 +### Fix +- ALFunction is not a function (Fixes [#71](https://github.com/DSaladinCH/al-object-helper/issues/71)) + ## [2.3.0] - 2022-12-06 ### Add - Performance Modes @@ -226,6 +230,7 @@ All versions of AL Object Helper will be documented in this file. ## [1.0.0] - 2020-06-24 - Initial release +[2.3.1]: https://github.com/DSaladinCH/al-object-helper/compare/2.3.0...2.3.1 [2.3.0]: https://github.com/DSaladinCH/al-object-helper/compare/2.2.13...2.3.0 [2.2.13]: https://github.com/DSaladinCH/al-object-helper/compare/2.2.12...2.2.13 [2.2.12]: https://github.com/DSaladinCH/al-object-helper/compare/2.2.10...2.2.12